Add missing SpecifiedTypes for count and strlen identical expressions #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Feb 17, 2022
|
Thank you! |
herndlm
deleted the
add-missing-specified-types-for-count-and-strlen-expressions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled over this while debugging something in the webmozart-assert extension.
This adds missing
SpecifiedTypesforcount,sizeofandstrlenexpressions used viaIdentical.E.g.
count($list) === 1would previously result in the sureTypeNonEmptyArrayTypefor$list. Now additionally it has aConstantIntegerTypewith value 1 forcount($list).This is a tiny thing, but improved something in
bug-2648.phpand it should close phpstan/phpstan-webmozart-assert#68 if I'm not mistaken.The first new test case in
TypeSpecifierTestCaseshows that it worked already forGreaterOrEqualbefore.