New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer verify types, when TypeSpecifyingExtension uses $overwrite=true #1011
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
<?php declare(strict_types = 1); | ||
|
||
namespace PHPStan\Rules\Comparison; | ||
|
||
use PHPStan\Rules\Rule; | ||
use PHPStan\Testing\RuleTestCase; | ||
|
||
/** | ||
* @extends RuleTestCase<ImpossibleCheckTypeMethodCallRule> | ||
*/ | ||
class ImpossibleCheckTypeGenericOverwriteRuleTest extends RuleTestCase | ||
{ | ||
|
||
private bool $treatPhpDocTypesAsCertain; | ||
|
||
public function getRule(): Rule | ||
{ | ||
return new ImpossibleCheckTypeMethodCallRule( | ||
new ImpossibleCheckTypeHelper( | ||
$this->createReflectionProvider(), | ||
$this->getTypeSpecifier(), | ||
[], | ||
$this->treatPhpDocTypesAsCertain, | ||
), | ||
true, | ||
$this->treatPhpDocTypesAsCertain, | ||
); | ||
} | ||
|
||
public function testNoReportedErrorOnOverwrite(): void | ||
{ | ||
$this->treatPhpDocTypesAsCertain = false; | ||
|
||
$this->analyse([__DIR__ . '/data/generic-type-override.php'], []); | ||
} | ||
|
||
public static function getAdditionalConfigFiles(): array | ||
{ | ||
return [ | ||
__DIR__ . '/impossible-check-type-generic-overwrite.neon', | ||
]; | ||
} | ||
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
<?php declare(strict_types = 1); | ||
|
||
namespace PHPStan\Rules\Comparison; | ||
|
||
use PhpParser\Node\Expr\MethodCall; | ||
use PHPStan\Analyser\Scope; | ||
use PHPStan\Analyser\SpecifiedTypes; | ||
use PHPStan\Analyser\TypeSpecifier; | ||
use PHPStan\Analyser\TypeSpecifierAwareExtension; | ||
use PHPStan\Analyser\TypeSpecifierContext; | ||
use PHPStan\Reflection\MethodReflection; | ||
use PHPStan\Type\MethodTypeSpecifyingExtension; | ||
use PHPStan\Type\StringType; | ||
use PHPStan\Type\Generic\GenericObjectType; | ||
|
||
class GenericTypeOverride implements MethodTypeSpecifyingExtension, TypeSpecifierAwareExtension | ||
{ | ||
|
||
/** @var TypeSpecifier */ | ||
private $typeSpecifier; | ||
|
||
public function setTypeSpecifier(TypeSpecifier $typeSpecifier): void | ||
{ | ||
$this->typeSpecifier = $typeSpecifier; | ||
} | ||
|
||
public function getClass(): string | ||
{ | ||
return \GenericTypeOverride\Foo::class; | ||
} | ||
|
||
public function isMethodSupported( | ||
MethodReflection $methodReflection, | ||
MethodCall $node, | ||
TypeSpecifierContext $context | ||
): bool | ||
{ | ||
return $methodReflection->getName() === 'setFetchMode'; | ||
} | ||
|
||
public function specifyTypes( | ||
MethodReflection $methodReflection, | ||
MethodCall $node, | ||
Scope $scope, | ||
TypeSpecifierContext $context | ||
): SpecifiedTypes | ||
{ | ||
$newType = new GenericObjectType(\GenericTypeOverride\Foo::class, [\GenericTypeOverride\Bar::class]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't how the constructor should be called. The constructor looks like this:
You need There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thx for catching. with this fix, the unit test works like expected:
I am wondering whether phpstan should have errored about this when scanning the test-case? |
||
|
||
return $this->typeSpecifier->create( | ||
$node->var, | ||
$newType, | ||
TypeSpecifierContext::createTruthy(), | ||
true | ||
); | ||
} | ||
|
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
<?php | ||
|
||
namespace GenericTypeOverride; | ||
|
||
use function PHPStan\Testing\assertType; | ||
|
||
class Test { | ||
public function doFoo() { | ||
$foo = $this->createGenericFoo(); | ||
assertType('Foo<int>', $foo); | ||
|
||
// $foo generic will be overridden via MethodTypeSpecifyingExtension | ||
$foo->setFetchMode(); | ||
assertType('Foo<Bar>', $foo); | ||
} | ||
|
||
/** | ||
* @return Foo<int> | ||
*/ | ||
public function createGenericFoo() { | ||
|
||
} | ||
} | ||
|
||
|
||
/** | ||
* @template T | ||
*/ | ||
class Foo | ||
{ | ||
public function setFetchMode() { | ||
|
||
} | ||
} | ||
|
||
|
||
class Bar | ||
{ | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
services: | ||
- | ||
class: PHPStan\Rules\Comparison\GenericTypeOverride | ||
tags: | ||
- phpstan.typeSpecifier.methodTypeSpecifyingExtension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need to be a property if you're not testing true/false scenarios. So please put "true" directly in the constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed