New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer verify types, when TypeSpecifyingExtension uses $overwrite=true #1011
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeGenericOverwriteRuleTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
<?php declare(strict_types = 1); | ||
|
||
namespace PHPStan\Rules\Comparison; | ||
|
||
use PHPStan\Rules\Rule; | ||
use PHPStan\Testing\RuleTestCase; | ||
|
||
/** | ||
* @extends RuleTestCase<ImpossibleCheckTypeMethodCallRule> | ||
*/ | ||
class ImpossibleCheckTypeGenericOverwriteRuleTest extends RuleTestCase | ||
{ | ||
|
||
private bool $treatPhpDocTypesAsCertain; | ||
|
||
public function getRule(): Rule | ||
{ | ||
return new ImpossibleCheckTypeMethodCallRule( | ||
new ImpossibleCheckTypeHelper( | ||
$this->createReflectionProvider(), | ||
$this->getTypeSpecifier(), | ||
[], | ||
$this->treatPhpDocTypesAsCertain, | ||
), | ||
true, | ||
$this->treatPhpDocTypesAsCertain, | ||
); | ||
} | ||
|
||
public function testNoReportedErrorOnOverwrite(): void | ||
{ | ||
$this->treatPhpDocTypesAsCertain = false; | ||
|
||
$this->analyse([__DIR__ . '/data/generic-type-override.php'], []); | ||
} | ||
|
||
public static function getAdditionalConfigFiles(): array | ||
{ | ||
return [ | ||
__DIR__ . '/impossible-check-type-generic-overwrite.neon', | ||
]; | ||
} | ||
|
||
} |
58 changes: 58 additions & 0 deletions
58
tests/PHPStan/Rules/Comparison/data/TestTypeOverwriteSpecifyingExtensions.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
<?php declare(strict_types = 1); | ||
|
||
namespace PHPStan\Rules\Comparison; | ||
|
||
use PhpParser\Node\Expr\MethodCall; | ||
use PHPStan\Analyser\Scope; | ||
use PHPStan\Analyser\SpecifiedTypes; | ||
use PHPStan\Analyser\TypeSpecifier; | ||
use PHPStan\Analyser\TypeSpecifierAwareExtension; | ||
use PHPStan\Analyser\TypeSpecifierContext; | ||
use PHPStan\Reflection\MethodReflection; | ||
use PHPStan\Type\MethodTypeSpecifyingExtension; | ||
use PHPStan\Type\ObjectType; | ||
use PHPStan\Type\Generic\GenericObjectType; | ||
|
||
class GenericTypeOverride implements MethodTypeSpecifyingExtension, TypeSpecifierAwareExtension | ||
{ | ||
|
||
/** @var TypeSpecifier */ | ||
private $typeSpecifier; | ||
|
||
public function setTypeSpecifier(TypeSpecifier $typeSpecifier): void | ||
{ | ||
$this->typeSpecifier = $typeSpecifier; | ||
} | ||
|
||
public function getClass(): string | ||
{ | ||
return \GenericTypeOverride\Foo::class; | ||
} | ||
|
||
public function isMethodSupported( | ||
MethodReflection $methodReflection, | ||
MethodCall $node, | ||
TypeSpecifierContext $context | ||
): bool | ||
{ | ||
return $methodReflection->getName() === 'setFetchMode'; | ||
} | ||
|
||
public function specifyTypes( | ||
MethodReflection $methodReflection, | ||
MethodCall $node, | ||
Scope $scope, | ||
TypeSpecifierContext $context | ||
): SpecifiedTypes | ||
{ | ||
$newType = new GenericObjectType(\GenericTypeOverride\Foo::class, [new ObjectType(\GenericTypeOverride\Bar::class)]); | ||
|
||
return $this->typeSpecifier->create( | ||
$node->var, | ||
$newType, | ||
TypeSpecifierContext::createTruthy(), | ||
true | ||
); | ||
} | ||
|
||
} |
39 changes: 39 additions & 0 deletions
39
tests/PHPStan/Rules/Comparison/data/generic-type-override.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
<?php | ||
|
||
namespace GenericTypeOverride; | ||
|
||
use function PHPStan\Testing\assertType; | ||
|
||
class Test { | ||
public function doFoo() { | ||
$foo = $this->createGenericFoo(); | ||
assertType('Foo<int>', $foo); | ||
|
||
// $foo generic will be overridden via MethodTypeSpecifyingExtension | ||
$foo->setFetchMode(); | ||
assertType('Foo<Bar>', $foo); | ||
} | ||
|
||
/** | ||
* @return Foo<int> | ||
*/ | ||
public function createGenericFoo() { | ||
|
||
} | ||
} | ||
|
||
|
||
/** | ||
* @template T | ||
*/ | ||
class Foo | ||
{ | ||
public function setFetchMode() { | ||
|
||
} | ||
} | ||
|
||
|
||
class Bar | ||
{ | ||
} |
5 changes: 5 additions & 0 deletions
5
tests/PHPStan/Rules/Comparison/impossible-check-type-generic-overwrite.neon
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
services: | ||
- | ||
class: PHPStan\Rules\Comparison\GenericTypeOverride | ||
tags: | ||
- phpstan.typeSpecifier.methodTypeSpecifyingExtension |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need to be a property if you're not testing true/false scenarios. So please put "true" directly in the constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed