Split TemplateType::isSubTypeOf() and TemplateType::isAcceptedBy() #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, let's 🚢 this :) |
|
I've marked the PR as ready 🚢🚢🚢 However I'm not super confident about everything in this PR yet, and I'll be AFK for a few days, so I wouldn't mind if this was not merged immediately. |
|
The worst thing that can happen are infinite recursions. We're not gaining anything by making it sit here, there's at least a chance we will gather some feedback when it's merged and there's something wrong with it :) In the worst case scenario it can be reverted. There won't be a release for a few days anyway so don't worry too much :) Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TemplateType::isAcceptedBy() delegates to TemplateType::isSubTypeOf(). Because of this, bounds are compared with isSubTypeOf(), which gives undesirable results in the context of isAcceptedBy().
For instance,
ArrayAccess->isSuperTypeOf(Traversable)beingmaybecauses(T of ArrayAccess)->accepts(Traversable)to bemaybeas well.In this PR I split the implementations of
TemplateType::isSubTypeOf()andTemplateType::isAcceptedBy(), so thatisAcceptedBy()can compare bounds withaccepts().This fixes phpstan/phpstan#6589