ConstantConditionRuleHelper - do not report empty(), it has a separat…

…e rule
phpstan · Jan 31, 2022 · fe26263 · fe26263
1 parent 3b17acc
commit fe26263
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/Rules/Comparison/ConstantConditionRuleHelper.php b/src/Rules/Comparison/ConstantConditionRuleHelper.php
@@ -24,7 +24,8 @@ public function shouldReportAlwaysTrueByDefault(Expr $expr): bool
 			|| $expr instanceof Expr\BinaryOp\BooleanOr
 			|| $expr instanceof Expr\BinaryOp\BooleanAnd
 			|| $expr instanceof Expr\Ternary
-			|| $expr instanceof Expr\Isset_;
+			|| $expr instanceof Expr\Isset_
+			|| $expr instanceof Expr\Empty_;
 	}
 
 	public function shouldSkip(Scope $scope, Expr $expr): bool
@@ -38,6 +39,7 @@ public function shouldSkip(Scope $scope, Expr $expr): bool
 			|| $expr instanceof Expr\BinaryOp\BooleanAnd
 			|| $expr instanceof Expr\Ternary
 			|| $expr instanceof Expr\Isset_
+			|| $expr instanceof Expr\Empty_
 			|| $expr instanceof Expr\BinaryOp\Greater
 			|| $expr instanceof Expr\BinaryOp\GreaterOrEqual
 			|| $expr instanceof Expr\BinaryOp\Smaller

diff --git a/tests/PHPStan/Rules/Comparison/data/if-condition.php b/tests/PHPStan/Rules/Comparison/data/if-condition.php
@@ -293,3 +293,20 @@ public function nestedIfConditions($mixed): void
 		}
 	}
 }
+
+class EmptyCondition
+{
+
+	public function doFoo()
+	{
+		$a = 1;
+		if (empty($a)) {
+
+		}
+
+		if (empty($b)) {
+
+		}
+	}
+
+}