Prevent overly greedy $scope->getType() calls in Arrays*Rules

phpstan · Dec 13, 2022 · fcee93f · fcee93f
1 parent 8c58c09
commit fcee93f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/Rules/Arrays/OffsetAccessValueAssignmentRule.php b/src/Rules/Arrays/OffsetAccessValueAssignmentRule.php
@@ -53,7 +53,6 @@ public function processNode(Node $node, Scope $scope): array
 			$assignedValueType = $scope->getType($node);
 		}
 
-		$originalArrayType = $scope->getType($arrayDimFetch->var);
 		$arrayTypeResult = $this->ruleLevelHelper->findTypeToCheck(
 			$scope,
 			$arrayDimFetch->var,
@@ -76,6 +75,8 @@ static function (Type $varType) use ($assignedValueType): bool {
 			return [];
 		}
 
+		$originalArrayType = $scope->getType($arrayDimFetch->var);
+
 		return [
 			RuleErrorBuilder::message(sprintf(
 				'%s does not accept %s.',