Keep numeric-strings in str_repeat()

phpstan · Feb 19, 2024 · f4b72a7 · f4b72a7
1 parent 299df51
commit f4b72a7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/Type/Php/StrRepeatFunctionReturnTypeExtension.php b/src/Type/Php/StrRepeatFunctionReturnTypeExtension.php
@@ -8,6 +8,7 @@
 use PHPStan\Type\Accessory\AccessoryLiteralStringType;
 use PHPStan\Type\Accessory\AccessoryNonEmptyStringType;
 use PHPStan\Type\Accessory\AccessoryNonFalsyStringType;
+use PHPStan\Type\Accessory\AccessoryNumericStringType;
 use PHPStan\Type\Constant\ConstantIntegerType;
 use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\DynamicFunctionReturnTypeExtension;
@@ -74,6 +75,10 @@ public function getTypeFromFunctionCall(
 			$accessoryTypes[] = new AccessoryLiteralStringType();
 		}
 
+		if ($inputType->isNumericString()->yes()) {
+			$accessoryTypes[] = new AccessoryNumericStringType();
+		}
+
 		if (count($accessoryTypes) > 0) {
 			$accessoryTypes[] = new StringType();
 			return new IntersectionType($accessoryTypes);

diff --git a/tests/PHPStan/Analyser/data/literal-string.php b/tests/PHPStan/Analyser/data/literal-string.php
@@ -34,6 +34,8 @@ public function doFoo($literalString, string $string)
 			str_repeat('a', 99)
 		);
 		assertType('literal-string&non-falsy-string', str_repeat('a', 100));
+		assertType('literal-string&non-empty-string&numeric-string', str_repeat('0', 100));
+		assertType('literal-string&non-falsy-string&numeric-string', str_repeat('1', 100));
 		assertType("'?,?,?,'", str_repeat('?,', 3));
 		assertType("*NEVER*", str_repeat('?,', -3));