Prevent overly greedy $scope->getType() calls in Comparison*Rules

phpstan · Dec 13, 2022 · e3873d8 · e3873d8
1 parent 0f7d3d6
commit e3873d8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 14 deletions.
diff --git a/src/Rules/Comparison/ConstantLooseComparisonRule.php b/src/Rules/Comparison/ConstantLooseComparisonRule.php
@@ -36,25 +36,22 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$leftType = $scope->getType($node->left);
-		$rightType = $scope->getType($node->right);
-
 		if (!$nodeType->getValue()) {
 			return [
 				RuleErrorBuilder::message(sprintf(
 					'Loose comparison using %s between %s and %s will always evaluate to false.',
 					$node instanceof Node\Expr\BinaryOp\Equal ? '==' : '!=',
-					$leftType->describe(VerbosityLevel::value()),
-					$rightType->describe(VerbosityLevel::value()),
+					$scope->getType($node->left)->describe(VerbosityLevel::value()),
+					$scope->getType($node->right)->describe(VerbosityLevel::value()),
 				))->build(),
 			];
 		} elseif ($this->checkAlwaysTrueLooseComparison) {
 			return [
 				RuleErrorBuilder::message(sprintf(
 					'Loose comparison using %s between %s and %s will always evaluate to true.',
 					$node instanceof Node\Expr\BinaryOp\Equal ? '==' : '!=',
-					$leftType->describe(VerbosityLevel::value()),
-					$rightType->describe(VerbosityLevel::value()),
+					$scope->getType($node->left)->describe(VerbosityLevel::value()),
+					$scope->getType($node->right)->describe(VerbosityLevel::value()),
 				))->build(),
 			];
 		}

diff --git a/src/Rules/Comparison/ImpossibleCheckTypeHelper.php b/src/Rules/Comparison/ImpossibleCheckTypeHelper.php
@@ -154,14 +154,14 @@ public function findSpecifiedType(
 					}
 				} elseif ($functionName === 'method_exists' && $argsCount >= 2) {
 					$objectType = $scope->getType($node->getArgs()[0]->value);
-					$methodType = $scope->getType($node->getArgs()[1]->value);
 
 					if ($objectType instanceof ConstantStringType
 						&& !$this->reflectionProvider->hasClass($objectType->getValue())
 					) {
 						return false;
 					}
 
+					$methodType = $scope->getType($node->getArgs()[1]->value);
 					if ($methodType instanceof ConstantStringType) {
 						if ($objectType instanceof ConstantStringType) {
 							$objectType = new ObjectType($objectType->getValue());

diff --git a/src/Rules/Comparison/UsageOfVoidMatchExpressionRule.php b/src/Rules/Comparison/UsageOfVoidMatchExpressionRule.php
@@ -20,12 +20,11 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		$matchResultType = $scope->getType($node);
-		if (
-			$matchResultType->isVoid()->yes()
-			&& !$scope->isInFirstLevelStatement()
-		) {
-			return [RuleErrorBuilder::message('Result of match expression (void) is used.')->build()];
+		if (!$scope->isInFirstLevelStatement()) {
+			$matchResultType = $scope->getType($node);
+			if ($matchResultType->isVoid()->yes()) {
+				return [RuleErrorBuilder::message('Result of match expression (void) is used.')->build()];
+			}
 		}
 
 		return [];