better handling of having arguments provided

phpstan · Dec 15, 2022 · e0aa795 · e0aa795
1 parent 93e479e
commit e0aa795
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Type/Php/DateIntervalDynamicReturnTypeExtension.php b/src/Type/Php/DateIntervalDynamicReturnTypeExtension.php
@@ -31,7 +31,13 @@ public function isStaticMethodSupported(MethodReflection $methodReflection): boo
 
 	public function getTypeFromStaticMethodCall(MethodReflection $methodReflection, StaticCall $methodCall, Scope $scope): ?Type
 	{
-		$strings = $scope->getType($methodCall->getArgs()[0]->value)->getConstantStrings();
+		$arguments = $methodCall->getArgs();
+
+		if (!isset($arguments[0])) {
+			return null;
+		}
+
+		$strings = $scope->getType($arguments[0]->value)->getConstantStrings();
 
 		$possibleReturnTypes = array_map(
 			static fn (ConstantStringType $s): string => gettype(@DateInterval::createFromDateString($s->getValue())),

diff --git a/tests/PHPStan/Analyser/data/bug-8442.php b/tests/PHPStan/Analyser/data/bug-8442.php
@@ -32,5 +32,7 @@ function () {
 	}
 
 	assertType('false', DateInterval::createFromDateString($interval));
+
+	DateInterval::createFromDateString();
 };