micro optimization

phpstan · Dec 17, 2022 · b4719b8 · b4719b8
1 parent 7581b9e
commit b4719b8
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/Type/TypeCombinator.php b/src/Type/TypeCombinator.php
@@ -512,11 +512,11 @@ private static function processArrayAccessoryTypes(array $arrayTypes): array
 					if ($innerType instanceof TemplateType) {
 						break;
 					}
-					if ($innerType instanceof HasOffsetValueType) {
-						$accessoryTypes[sprintf('hasOffsetValue(%s)', $innerType->getOffsetType()->describe(VerbosityLevel::cache()))][$i] = $innerType;
+					if (!($innerType instanceof AccessoryType) && !($innerType instanceof CallableType)) {
 						continue;
 					}
-					if (!($innerType instanceof AccessoryType) && !($innerType instanceof CallableType)) {
+					if ($innerType instanceof HasOffsetValueType) {
+						$accessoryTypes[sprintf('hasOffsetValue(%s)', $innerType->getOffsetType()->describe(VerbosityLevel::cache()))][$i] = $innerType;
 						continue;
 					}
 
@@ -530,7 +530,7 @@ private static function processArrayAccessoryTypes(array $arrayTypes): array
 			$constantArrays = $arrayType->getConstantArrays();
 
 			foreach ($constantArrays as $constantArray) {
-				if (AccessoryArrayListType::isListTypeEnabled() && $constantArray->isList()->yes()) {
+				if ($constantArray->isList()->yes() && AccessoryArrayListType::isListTypeEnabled()) {
 					$list = new AccessoryArrayListType();
 					$accessoryTypes[$list->describe(VerbosityLevel::cache())][$i] = $list;
 				}
@@ -552,7 +552,7 @@ private static function processArrayAccessoryTypes(array $arrayTypes): array
 			}
 
 			if ($accessoryType[0] instanceof HasOffsetValueType) {
-				$commonAccessoryTypes[] = TypeCombinator::union(...$accessoryType);
+				$commonAccessoryTypes[] = self::union(...$accessoryType);
 				continue;
 			}