Update src/Type/Php/DateIntervalDynamicReturnTypeExtension.php

Co-authored-by: Markus Staab <maggus.staab@googlemail.com>
phpstan · Dec 14, 2022 · b00058d · b00058d
1 parent 330a2f5
commit b00058d
Showing 1 changed file with 18 additions and 7 deletions.
diff --git a/src/Type/Php/DateIntervalDynamicReturnTypeExtension.php b/src/Type/Php/DateIntervalDynamicReturnTypeExtension.php
@@ -28,15 +28,26 @@ public function isStaticMethodSupported(MethodReflection $methodReflection): boo
 
 	public function getTypeFromStaticMethodCall(MethodReflection $methodReflection, StaticCall $methodCall, Scope $scope): ?Type
 	{
-		$dateTimeString = TypeUtils::getConstantStrings($scope->getType($methodCall->getArgs()[0]->value));
-
-		if (!($dateTimeString instanceof ConstantStringType)) {
-			return null;
+		$strings = $scope->getType($methodCall->getArgs()[0]->value)->getConstantStrings();
+
+		if ($strings === []) {
+		   return null;
+		}
+
+		if (count($strings) === 1) {
+           if (DateInterval::createFromDateString($dateTimeString->getValue()) === false) {
+    		 return new ConstantBooleanType(false);
+           }
+           return new ObjectType(DateInterval::class);
+		}
+
+		foreach($strings as $string) {
+		  if (DateInterval::createFromDateString($dateTimeString->getValue()) === false) {
+		    return null;
+		  }
 		}
 
-		$isValid = DateInterval::createFromDateString($dateTimeString->getValue()) !== false;
-
-		return $isValid ? new ObjectType(DateInterval::class) : new ConstantBooleanType(false);
+		return new ObjectType(DateInterval::class);
 	}
 
 }