Adjust

phpstan · Jun 19, 2022 · 93d837b · 93d837b
1 parent 5aee7bf
commit 93d837b
Show file tree

Hide file tree

Showing 15 changed files with 11 additions and 60 deletions.
diff --git a/src/Reflection/Dummy/ChangedTypeMethodReflection.php b/src/Reflection/Dummy/ChangedTypeMethodReflection.php
@@ -89,9 +89,4 @@ public function hasSideEffects(): TrinaryLogic
 		return $this->reflection->hasSideEffects();
 	}
 
-	public function acceptsNamedArguments(): bool
-	{
-		return $this->reflection->acceptsNamedArguments();
-	}
-
 }
diff --git a/src/Reflection/Dummy/DummyConstructorReflection.php b/src/Reflection/Dummy/DummyConstructorReflection.php
@@ -91,11 +91,6 @@ public function hasSideEffects(): TrinaryLogic
 		return TrinaryLogic::createNo();
 	}
 
-	public function acceptsNamedArguments(): bool
-	{
-		return true;
-	}
-
 	public function getDocComment(): ?string
 	{
 		return null;

diff --git a/src/Reflection/Dummy/DummyMethodReflection.php b/src/Reflection/Dummy/DummyMethodReflection.php
@@ -91,11 +91,6 @@ public function hasSideEffects(): TrinaryLogic
 		return TrinaryLogic::createMaybe();
 	}
 
-	public function acceptsNamedArguments(): bool
-	{
-		return true;
-	}
-
 	public function getDocComment(): ?string
 	{
 		return null;

diff --git a/src/Reflection/ExtendedMethodReflection.php b/src/Reflection/ExtendedMethodReflection.php
@@ -16,4 +16,6 @@
 interface ExtendedMethodReflection extends MethodReflection
 {
 
+	public function acceptsNamedArguments(): bool;
+
 }
diff --git a/src/Reflection/MethodReflection.php b/src/Reflection/MethodReflection.php
@@ -30,6 +30,4 @@ public function getThrowType(): ?Type;
 
 	public function hasSideEffects(): TrinaryLogic;
 
-	public function acceptsNamedArguments(): bool;
-
 }
diff --git a/src/Reflection/Mixin/MixinMethodReflection.php b/src/Reflection/Mixin/MixinMethodReflection.php
@@ -85,9 +85,4 @@ public function hasSideEffects(): TrinaryLogic
 		return $this->reflection->hasSideEffects();
 	}
 
-	public function acceptsNamedArguments(): bool
-	{
-		return $this->reflection->acceptsNamedArguments();
-	}
-
 }
diff --git a/src/Reflection/Php/ClosureCallMethodReflection.php b/src/Reflection/Php/ClosureCallMethodReflection.php
@@ -118,9 +118,4 @@ public function hasSideEffects(): TrinaryLogic
 		return $this->nativeMethodReflection->hasSideEffects();
 	}
 
-	public function acceptsNamedArguments(): bool
-	{
-		return $this->nativeMethodReflection->acceptsNamedArguments();
-	}
-
 }
diff --git a/src/Reflection/Php/PhpClassReflectionExtension.php b/src/Reflection/Php/PhpClassReflectionExtension.php
@@ -705,6 +705,7 @@ private function createMethod(
 		$isInternal = $resolvedPhpDoc->isInternal();
 		$isFinal = $resolvedPhpDoc->isFinal();
 		$isPure = $resolvedPhpDoc->isPure();
+		$acceptsNamedArguments = $resolvedPhpDoc->acceptsNamedArguments();
 
 		return $this->methodReflectionFactory->create(
 			$declaringClass,
@@ -719,6 +720,7 @@ private function createMethod(
 			$isInternal,
 			$isFinal,
 			$isPure,
+			$acceptsNamedArguments,
 		);
 	}
 

diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -78,7 +78,7 @@ public function __construct(
 		private bool $isInternal,
 		private bool $isFinal,
 		private ?bool $isPure,
-		private bool $acceptsNamedArguments = true,
+		private bool $acceptsNamedArguments,
 	)
 	{
 	}

diff --git a/src/Reflection/Php/PhpMethodReflectionFactory.php b/src/Reflection/Php/PhpMethodReflectionFactory.php
@@ -26,6 +26,7 @@ public function create(
 		bool $isInternal,
 		bool $isFinal,
 		?bool $isPure = null,
+		bool $acceptsNamedArguments = true,
 	): PhpMethodReflection;
 
 }
diff --git a/src/Reflection/Php/Soap/SoapClientMethodReflection.php b/src/Reflection/Php/Soap/SoapClientMethodReflection.php
@@ -97,9 +97,4 @@ public function hasSideEffects(): TrinaryLogic
 		return TrinaryLogic::createYes();
 	}
 
-	public function acceptsNamedArguments(): bool
-	{
-		return true;
-	}
-
 }
diff --git a/src/Reflection/ResolvedMethodReflection.php b/src/Reflection/ResolvedMethodReflection.php
@@ -115,9 +115,4 @@ public function hasSideEffects(): TrinaryLogic
 		return $this->reflection->hasSideEffects();
 	}
 
-	public function acceptsNamedArguments(): bool
-	{
-		return $this->reflection->acceptsNamedArguments();
-	}
-
 }
diff --git a/src/Reflection/Type/IntersectionTypeMethodReflection.php b/src/Reflection/Type/IntersectionTypeMethodReflection.php
@@ -147,17 +147,6 @@ public function hasSideEffects(): TrinaryLogic
 		return TrinaryLogic::maxMin(...array_map(static fn (MethodReflection $method): TrinaryLogic => $method->hasSideEffects(), $this->methods));
 	}
 
-	public function acceptsNamedArguments(): bool
-	{
-		foreach ($this->methods as $method) {
-			if (!$method->acceptsNamedArguments()) {
-				return false;
-			}
-		}
-
-		return true;
-	}
-
 	public function getDocComment(): ?string
 	{
 		return null;

diff --git a/src/Reflection/Type/UnionTypeMethodReflection.php b/src/Reflection/Type/UnionTypeMethodReflection.php
@@ -148,17 +148,6 @@ public function hasSideEffects(): TrinaryLogic
 		return TrinaryLogic::extremeIdentity(...array_map(static fn (MethodReflection $method): TrinaryLogic => $method->hasSideEffects(), $this->methods));
 	}
 
-	public function acceptsNamedArguments(): bool
-	{
-		foreach ($this->methods as $method) {
-			if (!$method->acceptsNamedArguments()) {
-				return false;
-			}
-		}
-
-		return true;
-	}
-
 	public function getDocComment(): ?string
 	{
 		return null;

diff --git a/src/Reflection/WrappedExtendedMethodReflection.php b/src/Reflection/WrappedExtendedMethodReflection.php
@@ -82,4 +82,9 @@ public function hasSideEffects(): TrinaryLogic
 		return $this->method->hasSideEffects();
 	}
 
+	public function acceptsNamedArguments(): bool
+	{
+		return true;
+	}
+
 }