Prevent overly greedy $scope->getType() calls in ExistingClassInInsta…

…nceOfRule
phpstan · Dec 13, 2022 · 93a741e · 93a741e
1 parent d5a8d9e
commit 93a741e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/Rules/Classes/ExistingClassInInstanceOfRule.php b/src/Rules/Classes/ExistingClassInInstanceOfRule.php
@@ -77,9 +77,10 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$classReflection = $this->reflectionProvider->getClass($name);
-		$expressionType = $scope->getType($node->expr);
 
 		if ($classReflection->isTrait()) {
+			$expressionType = $scope->getType($node->expr);
+
 			$errors[] = RuleErrorBuilder::message(sprintf(
 				'Instanceof between %s and trait %s will always evaluate to false.',
 				$expressionType->describe(VerbosityLevel::typeOnly()),