Revert "Passing a variable by reference to a function and method has …

…side effects" This reverts commit 1070788.
phpstan · Jan 8, 2023 · 705d0f8 · 705d0f8
1 parent 35e4813
commit 705d0f8
Show file tree

Hide file tree

Showing 10 changed files with 0 additions and 91 deletions.
diff --git a/src/Reflection/Annotations/AnnotationMethodReflection.php b/src/Reflection/Annotations/AnnotationMethodReflection.php
@@ -113,14 +113,6 @@ public function hasSideEffects(): TrinaryLogic
 			return TrinaryLogic::createYes();
 		}
 
-		foreach ($this->getVariants() as $variant) {
-			foreach ($variant->getParameters() as $parameter) {
-				if ($parameter->passedByReference()->yes()) {
-					return TrinaryLogic::createYes();
-				}
-			}
-		}
-
 		return TrinaryLogic::createMaybe();
 	}
 

diff --git a/src/Reflection/Native/NativeFunctionReflection.php b/src/Reflection/Native/NativeFunctionReflection.php
@@ -81,13 +81,6 @@ public function hasSideEffects(): TrinaryLogic
 		if ($this->isVoid()) {
 			return TrinaryLogic::createYes();
 		}
-		foreach ($this->variants as $variant) {
-			foreach ($variant->getParameters() as $parameter) {
-				if ($parameter->passedByReference()->yes()) {
-					return TrinaryLogic::createYes();
-				}
-			}
-		}
 
 		return $this->hasSideEffects;
 	}

diff --git a/src/Reflection/Native/NativeMethodReflection.php b/src/Reflection/Native/NativeMethodReflection.php
@@ -136,13 +136,6 @@ public function hasSideEffects(): TrinaryLogic
 		) {
 			return TrinaryLogic::createYes();
 		}
-		foreach ($this->variants as $variant) {
-			foreach ($variant->getParameters() as $parameter) {
-				if ($parameter->passedByReference()->yes()) {
-					return TrinaryLogic::createYes();
-				}
-			}
-		}
 
 		return $this->hasSideEffects;
 	}

diff --git a/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php b/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php
@@ -199,13 +199,6 @@ public function hasSideEffects(): TrinaryLogic
 		if ($this->isPure !== null) {
 			return TrinaryLogic::createFromBoolean(!$this->isPure);
 		}
-		foreach ($this->getVariants() as $variant) {
-			foreach ($variant->getParameters() as $parameter) {
-				if ($parameter->passedByReference()->yes()) {
-					return TrinaryLogic::createYes();
-				}
-			}
-		}
 
 		return TrinaryLogic::createMaybe();
 	}

diff --git a/src/Reflection/Php/PhpFunctionReflection.php b/src/Reflection/Php/PhpFunctionReflection.php
@@ -245,13 +245,6 @@ public function hasSideEffects(): TrinaryLogic
 		if ($this->isPure !== null) {
 			return TrinaryLogic::createFromBoolean(!$this->isPure);
 		}
-		foreach ($this->getVariants() as $variant) {
-			foreach ($variant->getParameters() as $parameter) {
-				if ($parameter->passedByReference()->yes()) {
-					return TrinaryLogic::createYes();
-				}
-			}
-		}
 
 		return TrinaryLogic::createMaybe();
 	}

diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -416,13 +416,6 @@ public function hasSideEffects(): TrinaryLogic
 		if ($this->isPure !== null) {
 			return TrinaryLogic::createFromBoolean(!$this->isPure);
 		}
-		foreach ($this->getVariants() as $variant) {
-			foreach ($variant->getParameters() as $parameter) {
-				if ($parameter->passedByReference()->yes()) {
-					return TrinaryLogic::createYes();
-				}
-			}
-		}
 
 		return TrinaryLogic::createMaybe();
 	}

diff --git a/tests/PHPStan/Analyser/NodeScopeResolverTest.php b/tests/PHPStan/Analyser/NodeScopeResolverTest.php
@@ -1171,7 +1171,6 @@ public function dataFileAsserts(): iterable
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8635.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8625.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8621.php');
-		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8084.php');
 	}
 
 	/**

diff --git a/tests/PHPStan/Analyser/data/bug-8084.php b/tests/PHPStan/Analyser/data/bug-8084.php
diff --git a/tests/PHPStan/Rules/Variables/NullCoalesceRuleTest.php b/tests/PHPStan/Rules/Variables/NullCoalesceRuleTest.php
@@ -360,12 +360,4 @@ public function testBug7968(): void
 		$this->analyse([__DIR__ . '/data/bug-7968.php'], []);
 	}
 
-	public function testBug8084(): void
-	{
-		$this->treatPhpDocTypesAsCertain = true;
-		$this->strictUnnecessaryNullsafePropertyFetch = true;
-
-		$this->analyse([__DIR__ . '/data/bug-8084.php'], []);
-	}
-
 }
diff --git a/tests/PHPStan/Rules/Variables/data/bug-8084.php b/tests/PHPStan/Rules/Variables/data/bug-8084.php