Regression tests

Closes phpstan/phpstan#2268
Closes phpstan/phpstan#2298
Closes phpstan/phpstan#1903

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -480,4 +480,10 @@ public function testBug4530(): void
 		$this->analyse([__DIR__ . '/data/bug-4530.php'], []);
 	}
 
+	public function testBug2268(): void
+	{
+		require_once __DIR__ . '/data/bug-2268.php';
+		$this->analyse([__DIR__ . '/data/bug-2268.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Functions/data/bug-2268.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace Bug2268;
+
+abstract class Message implements \ArrayAccess
+{
+	/**
+	 * @param string $value
+	 */
+	abstract public function offsetSet($key, $value);
+}
+
+
+function test(Message $data)
+{
+	if (isset($data['name'])) {
+		$data['name'] = 1;
+	}
+
+	test($data);
+}

tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -1786,4 +1786,12 @@ public function testBug2837(): void
 		$this->analyse([__DIR__ . '/data/bug-2837.php'], []);
 	}
 
+	public function testBug2298(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkNullables = true;
+		$this->checkUnionTypes = true;
+		$this->analyse([__DIR__ . '/data/bug-2298.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Methods/ReturnTypeRuleTest.php

@@ -396,4 +396,14 @@ public function testBug3997(): void
 		]);
 	}
 
+	public function testBug1903(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-1903.php'], [
+			/*[
+				'Method Bug1903\Test::doFoo() should return array but returns int.',
+				19,
+			],*/
+		]);
+	}
+
 }

tests/PHPStan/Rules/Methods/data/bug-1903.php

@@ -0,0 +1,22 @@
+<?php
+
+namespace Bug1903;
+
+class Test
+{
+
+	private $answersOrder = [];
+
+	public function doFoo(string $qId): array
+	{
+		if (null !== $this->answersOrder[$qId]) {
+			return $this->answersOrder[$qId];
+		}
+
+
+		$this->answersOrder[$qId] = 5;
+
+		return $this->answersOrder[$qId];
+	}
+
+}

tests/PHPStan/Rules/Methods/data/bug-2298.php

@@ -0,0 +1,40 @@
+<?php
+
+namespace Bug2298;
+
+abstract class BitbucketDriver
+{
+
+	/**
+	 * @var VcsDriver
+	 */
+	protected $fallbackDriver;
+
+	protected $rootIdentifier;
+
+}
+
+class HgBitbucketDriver extends BitbucketDriver
+{
+
+	public function getRootIdentifier(): string
+	{
+		if ($this->fallbackDriver) {
+			return $this->fallbackDriver->getRootIdentifier();
+		}
+
+		if (null === $this->rootIdentifier) {
+			return $this->fallbackDriver->getRootIdentifier();
+		}
+
+		return 'foo';
+	}
+
+}
+
+interface VcsDriver
+{
+
+	public function getRootIdentifier(): string;
+
+}