support fscanf(), because of same formatting rules

phpstan · Jun 17, 2022 · 4ed94b7 · 4ed94b7
1 parent 753b157
commit 4ed94b7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/Type/Php/SscanfFunctionDynamicReturnTypeExtension.php b/src/Type/Php/SscanfFunctionDynamicReturnTypeExtension.php
@@ -23,7 +23,7 @@ class SscanfFunctionDynamicReturnTypeExtension implements DynamicFunctionReturnT
 
 	public function isFunctionSupported(FunctionReflection $functionReflection): bool
 	{
-		return $functionReflection->getName() === 'sscanf';
+		return in_array($functionReflection->getName(), ['sscanf', 'fscanf'], true);
 	}
 
 	public function getTypeFromFunctionCall(

diff --git a/tests/PHPStan/Analyser/data/sscanf.php b/tests/PHPStan/Analyser/data/sscanf.php
@@ -2,15 +2,14 @@
 
 namespace Sscanf;
 
-use sscanf;
 use function PHPStan\Testing\assertType;
 
 function foo(string $s) {
 	assertType('int|null', sscanf($s, $s, $first, $second));
 	assertType('array|null', sscanf($s, $s));
 }
 
-function bar(string $s) {
+function sscanfFormatInference(string $s) {
 	assertType('int|null', sscanf('20-20', '%d-%d', $first, $second));
 	assertType('array{int, int}|null', sscanf('20-20', '%d-%d'));
 
@@ -30,3 +29,10 @@ function bar(string $s) {
 	assertType('int', $day);
 	assertType('int', $year);
 }
+
+function fscanfFormatInference($r) {
+	list($month, $day, $year) = fscanf($r, "%s %d %d");
+	assertType('string', $month);
+	assertType('int', $day);
+	assertType('int', $year);
+}