ApiInstanceofRule - allow instanceof PHPStan\Type\Type

phpstan · Jun 17, 2022 · 4482fe4 · 4482fe4
1 parent cc3cf88
commit 4482fe4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/Rules/Api/ApiInstanceofRule.php b/src/Rules/Api/ApiInstanceofRule.php
@@ -79,7 +79,7 @@ public function processNode(Node $node, Scope $scope): array
 	 */
 	private function processCoveredClass(Node\Expr\Instanceof_ $node, Scope $scope, ClassReflection $classReflection): array
 	{
-		if ($classReflection->isSubclassOf(Type::class)) {
+		if ($classReflection->getName() === Type::class || $classReflection->isSubclassOf(Type::class)) {
 			return [];
 		}
 

diff --git a/tests/PHPStan/Rules/Api/data/instanceof-out-of-phpstan.php b/tests/PHPStan/Rules/Api/data/instanceof-out-of-phpstan.php
@@ -63,4 +63,11 @@ public function doBar(Scope $scope): void
 		}
 	}
 
+	public function doBaz($mixed): void
+	{
+		if ($mixed instanceof Type) {
+
+		}
+	}
+
 }