Added test for function(method)s with pass by reference params

phpstan · Dec 17, 2022 · 325c917 · 325c917
1 parent b650894
commit 325c917
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 2 deletions.
diff --git a/tests/PHPStan/Analyser/data/bug-8084.php b/tests/PHPStan/Analyser/data/bug-8084.php
@@ -2,15 +2,19 @@
 
 namespace Bug8084;
 
+use Exception;
 use function array_shift;
 use function PHPStan\Testing\assertType;
 
 class Bug8084
 {
+	/**
+	 * @param array{a: 0, b?: 1} $arr
+	 * @throws Exception
+	 */
 	public function run(array $arr): void
 	{
-		/** @var array{a: 0, b?: 1} $arr */
-		assertType('0', array_shift($arr) ?? throw new \Exception());
+		assertType('0', array_shift($arr) ?? throw new Exception());
 		assertType('1|null', array_shift($arr));
 	}
 }
diff --git a/tests/PHPStan/Rules/Variables/NullCoalesceRuleTest.php b/tests/PHPStan/Rules/Variables/NullCoalesceRuleTest.php
@@ -360,4 +360,12 @@ public function testBug7968(): void
 		$this->analyse([__DIR__ . '/data/bug-7968.php'], []);
 	}
 
+	public function testBug8084(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->strictUnnecessaryNullsafePropertyFetch = true;
+
+		$this->analyse([__DIR__ . '/data/bug-8084.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Variables/data/bug-8084.php b/tests/PHPStan/Rules/Variables/data/bug-8084.php
@@ -0,0 +1,19 @@
+<?php
+
+namespace Bug8084;
+
+use Exception;
+use function array_shift;
+use function PHPStan\Testing\assertType;
+
+class Bug8084
+{
+	/**
+	 * @param array{a?: 0} $arr
+	 * @throws Exception
+	 */
+	public function run(array $arr): void
+	{
+		assertType('0|null', array_shift($arr) ?? throw new Exception());
+	}
+}