Fix numeric string ctype_digit always true type specifier result

phpstan · Sep 6, 2022 · 2d3fbfb · 2d3fbfb
1 parent 12e40f1
commit 2d3fbfb
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/src/Type/Php/CtypeDigitFunctionTypeSpecifyingExtension.php b/src/Type/Php/CtypeDigitFunctionTypeSpecifyingExtension.php
@@ -13,6 +13,7 @@
 use PHPStan\Type\Accessory\AccessoryNumericStringType;
 use PHPStan\Type\FunctionTypeSpecifyingExtension;
 use PHPStan\Type\IntegerRangeType;
+use PHPStan\Type\IntegerType;
 use PHPStan\Type\IntersectionType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\TypeCombinator;
@@ -38,6 +39,10 @@ public function specifyTypes(FunctionReflection $functionReflection, FuncCall $n
 			throw new ShouldNotHappenException();
 		}
 
+		if ($context->true() && $scope->getType($node->getArgs()[0]->value)->isNumericString()->yes()) {
+			return new SpecifiedTypes();
+		}
+
 		$types = [
 			IntegerRangeType::fromInterval(48, 57), // ASCII-codes for 0-9
 			IntegerRangeType::createAllGreaterThanOrEqualTo(256), // Starting from 256 ints are interpreted as strings

diff --git a/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php b/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php
@@ -629,4 +629,11 @@ public function testBug6599(): void
 		$this->analyse([__DIR__ . '/data/bug-6599.php'], []);
 	}
 
+	public function testBug7914(): void
+	{
+		$this->checkAlwaysTrueCheckTypeFunctionCall = true;
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-7914.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Comparison/data/bug-7914.php b/tests/PHPStan/Rules/Comparison/data/bug-7914.php
@@ -0,0 +1,14 @@
+<?php declare(strict_types = 1);
+
+namespace Bug7914;
+
+function foo(string $s): void
+{
+	if (is_numeric($s)) {
+		if (ctype_digit($s)) {
+			echo "I'm all-digit string";
+		} else {
+			echo "I'm a not all-digit string";
+		}
+	}
+}