Revert "Implement identical/equal comparisons on EnumCaseObjectType"

This reverts commit 5fc2bfd.

src/Reflection/InitializerExprTypeResolver.php

@@ -1303,10 +1303,6 @@ public function resolveIdenticalType(Type $leftType, Type $rightType): BooleanTy
 			return new ConstantBooleanType($leftType->getValue() === $rightType->getValue());
 		}
 
-		if ($leftType instanceof EnumCaseObjectType && $rightType instanceof EnumCaseObjectType) {
-			return new ConstantBooleanType($leftType->equals($rightType));
-		}
-
 		$isSuperset = $leftType->isSuperTypeOf($rightType);
 		if ($isSuperset->no()) {
 			return new ConstantBooleanType(false);
@@ -1323,10 +1319,8 @@ public function resolveEqualType(Type $leftType, Type $rightType): BooleanType
 	{
 		$integerType = new IntegerType();
 		$floatType = new FloatType();
-
 		if (
-			($leftType instanceof EnumCaseObjectType && $rightType instanceof EnumCaseObjectType)
-			|| ($leftType->isString()->yes() && $rightType->isString()->yes())
+			($leftType->isString()->yes() && $rightType->isString()->yes())
 			|| ($integerType->isSuperTypeOf($leftType)->yes() && $integerType->isSuperTypeOf($rightType)->yes())
 			|| ($floatType->isSuperTypeOf($leftType)->yes() && $floatType->isSuperTypeOf($rightType)->yes())
 		) {

tests/PHPStan/Rules/Comparison/IfConstantConditionRuleTest.php

@@ -4,7 +4,6 @@
 
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
-use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<IfConstantConditionRule>
@@ -130,27 +129,4 @@ public function testBug6902(): void
 		$this->analyse([__DIR__ . '/data/bug-6902.php'], []);
 	}
 
-	public function testBug8485(): void
-	{
-		if (PHP_VERSION_ID < 80100) {
-			$this->markTestSkipped('Test requires PHP 8.1.');
-		}
-
-		$this->treatPhpDocTypesAsCertain = true;
-		$this->analyse([__DIR__ . '/data/bug-8485.php'], [
-			[
-				'If condition is always true.',
-				19,
-			],
-			[
-				'If condition is always false.',
-				24,
-			],
-			[
-				'If condition is always false.',
-				29,
-			],
-		]);
-	}
-
 }

tests/PHPStan/Rules/Comparison/MatchExpressionRuleTest.php

@@ -153,11 +153,7 @@ public function testEnums(): void
 				56,
 			],
 			[
-				'Match arm comparison between MatchEnums\Foo::THREE and MatchEnums\Foo::THREE is always true.',
-				76,
-			],
-			[
-				'Match arm is unreachable because previous comparison is always true.',
+				'Match arm comparison between *NEVER* and MatchEnums\Foo is always false.',
 				77,
 			],
 		]);

tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php

@@ -607,37 +607,6 @@ public function testBug8158(): void
 		$this->analyse([__DIR__ . '/data/bug-8158.php'], []);
 	}
 
-	public function testBug8485(): void
-	{
-		if (PHP_VERSION_ID < 80100) {
-			$this->markTestSkipped('Test requires PHP 8.1.');
-		}
-
-		$this->checkAlwaysTrueStrictComparison = true;
-		$this->analyse([__DIR__ . '/data/bug-8485.php'], [
-			[
-				'Strict comparison using === between Bug8485\E::c and Bug8485\E::c will always evaluate to true.',
-				17,
-			],
-			[
-				'Strict comparison using === between Bug8485\F::c and Bug8485\E::c will always evaluate to false.',
-				22,
-			],
-			[
-				'Strict comparison using === between Bug8485\F::c and Bug8485\E::c will always evaluate to false.',
-				27,
-			],
-			[
-				'Strict comparison using === between Bug8485\F and Bug8485\E will always evaluate to false.',
-				35,
-			],
-			[
-				'Strict comparison using === between Bug8485\F and Bug8485\E::c will always evaluate to false.',
-				40,
-			],
-		]);
-	}
-
 	public function testPhpUnitIntegration(): void
 	{
 		$this->checkAlwaysTrueStrictComparison = true;