Support ORM's embeddables #108
Conversation
| @@ -64,9 +68,6 @@ public function processNode(Node $node, Scope $scope): array | |||
| } | |||
|
|
|||
| $className = $class->getName(); | |||
| if ($objectManager->getMetadataFactory()->isTransient($className)) { | |||
There was a problem hiding this comment.
I'm trying to figure out internally why the embeddables are considered transient, but removal of this check causes no test failures
There was a problem hiding this comment.
Also classes not managed by Doctrine will have an exception thrown a bit later while trying to get their metadata and will return early from the rule with no errors, so I believe the intent is preserved
There was a problem hiding this comment.
I've created an issue in ORM but I think we can continue without waiting for its resolution doctrine/orm#8006
|
PR is now ready :) |
|
Anybody? @lookyman @ondrejmirtes ? |
|
Hi, sorry for keeping you waiting, I'll look into this when I have the time. |
ondrejmirtes
force-pushed
the
master
branch
4 times, most recently
from
b2b2414
to
1fe21ab
Compare
|
Any news on this one? It would be helpful imo. :-) |
|
Looks like this PR has conflicts, but it would be helpful to have it merged :) |
ondrejmirtes
force-pushed
the
1.3.x
branch
2 times, most recently
from
aa4e98e
to
8b28264
Compare
Today at work I've realized there's currently no rules for ORM's embeddables so here's an attempt to change that :) I'll remove WIP once I'm done with my goals, for now I'm making a PR for early feedback (or to learn that somebody else is already working on this).
Goals: