Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove $trimStrings from ConstExprParser #154

Draft
wants to merge 1 commit into
base: 1.9.x
Choose a base branch
from
Draft

Remove $trimStrings from ConstExprParser #154

wants to merge 1 commit into from

Conversation

rvanvelzen
Copy link
Contributor

@rvanvelzen
Copy link
Contributor Author

This should be fine for the next major as it is a BC break.

@ondrejmirtes
Copy link
Member

I think we could decouple phpdoc-parser version from PHPStan so we could release 2.0 now and update to it in PHPStan 1.x :) On the other hand, this would be a PHPStan-userland BC break too, so it might not be a good idea...

@ondrejmirtes
Copy link
Member

Just checked in PHPStan and for PHPStan users it's not really a BC break because it's already called with true. The only exception are @method tags and that's fine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rvanvelzen @ondrejmirtes