Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial compatability support for PHP8.2 for readonly classes. #564

Closed
wants to merge 1 commit into from

Conversation

kschatzle
Copy link
Contributor

readonly classes will throw a ClassMirrorException until supported.

readonly classes will throw a ClassMirrorException until supported.
@ciaranmcnulty
Copy link
Member

What's the error currently when we try and extend readonly classes?

@kschatzle
Copy link
Contributor Author

kschatzle commented Sep 9, 2022

What's the error currently when we try and extend readonly classes?

PHP Fatal error:  Non-readonly class Double\Fixtures\Prophecy\ReadOnlyClass\P1 cannot extend readonly class Fixtures\Prophecy\ReadOnlyClass in %s/src/Prophecy/Doubler/Generator/ClassCreator.php(49) : eval()'d code on line 2

@gquemener
Copy link
Contributor

I have pushed a patch to support doubling readonly class.
It's available through this PR: #571

Would there be a mean of communication (chat/mailing list) to coordinate efforts around supporting 8.2?
I'd gladly help, however don't want to create noise if you have already defined a strategy (first convert fatal error into proper exception, then support feature one by one, for instance).

@ciaranmcnulty
Copy link
Member

Thanks for the effort, I've merged #571 so this is not needed

@ciaranmcnulty
Copy link
Member

@gquemener on the subject of coordination I'd prefer Issues here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants