Fix PHP 8.1 errors

[jaylinski]

Fixes PHP 8.1 errors in CI pipeline.

Closes #1397.

There are deprecation warnings, but the pipeline still succeeds.

PhpSpec/Locator/PSR0/PSR0Locator                                                  
 136  - it finds all resources from tracked specPath
      8192: SplFileInfo::__construct(): Passing null to parameter #1 ($filename) of type string is deprecated in
      /srv/app/vendor/phpspec/prophecy/src/Prophecy/Doubler/Generator/ClassCreator.php(49) : eval()'d code line 6

I think this is related to phpspec/prophecy#414.

[jaylinski]

As mentioned in #1397 (comment), this comment was added instead of the void return type in order to preserve backwards compatibility.

[jaylinski]

This will break if PHP returns a token-array with only one item. Can I count on the array to always have a 1-index or should I check for it explicitly? 🤔

[webignition]

I'd say that the explicit check isn't hard to add but might make the code somewhat harder to understand:

if ($token == '|' || $token == '&' || (is_array($token) && ($token[1] ?? '') == '&')) {
    //...
}

It could be more readable by separating out the expression into independent booleans:

$isFoo = is_string($token) && $token == '|' || $token == '&';
$isBar = is_array($token) && ($token[1] ?? '') == '&';

if ($isFoo || $isBar) {
    return false;
}

Best of luck with naming $isFoo and $isBar correctly ...

[jaylinski]

@ciaranmcnulty If I can help you to review this PR in any way, please let me know.

[shouze]

@ciaranmcnulty If I can help you to review this PR in any way, please let me know.

FYI I've forked and applied all the patches in the suggested order (see #1402 (comment)) and I can confirm that by using this fork we've been able to finish our Symfony 6 migration and to upgrade from php 8 to 8.1.

Everything works as expected since few days 👌

https://github.com/gogaille/phpspec/tree/php-81-and-symfony-6

[lchrusciel]

We can also confirm that it works - https://github.com/loic425/Sylius/runs/5037334478 (thanks @loic425 for branch).

[Zales0123]

Hello, it's a friendly 2-weeks reminder about this PR 😄 👋 @ciaranmcnulty do you think it's possible to be merged in the predictable future? Maybe someone else from PHPSpec Organization has some info? @MarcelloDuarte @stof? 🚀