Add linter task to phing for checking old PHP versions

[rsynnest]

Closes #1709

[terrafrost]

In .travis.yml codesniffer is setup to run on PHP 5.5:

https://github.com/phpseclib/phpseclib/blob/1.0/.travis.yml#L36

One thing I feel like we could do is to update the .travis.yml on, say, PHP 5.6 or whatever, to lint for every version of PHP. Or at the very least lint for versions of PHP for which there aren't unit tests.

So like even tho the Travis CI "container" is running PHP 5.6, using Docker containers, it could still lint on PHP 4.4, PHP 5.0, etc.

I suppose something else we could do is to have a new build version [i]just[/i] for linting. This build version could be identified by the use of a custom env variable as is done here:

terrafrost/php-amqplib@317f91e

This .travis.yml might help as well:

https://github.com/phpseclib/benchmarks/blob/bcmath-no-openssl/.travis.yml

It'd also be good to have this on phpseclib 1.0 since that can run on PHP 4.4+. phpseclib 2.0 requires PHP 5.3+ but it's no longer being tested on PHP 5.3 via continuous integration as of 0539780

idk I just think having this linting done via continuous integration would be really cool!

[rsynnest]

CI is definitely the place, I'll look into adding it. I use Gitlab CI so didn't know to look for a .travis.yml

…

On Mon, Nov 8, 2021, 8:39 PM terrafrost ***@***.***> wrote: In .travis.yml codesniffer is setup to run on PHP 5.5: https://github.com/phpseclib/phpseclib/blob/1.0/.travis.yml#L36 One thing I feel like we could do is to update the .travis.yml on, say, PHP 5.6 or whatever, to lint for every version of PHP. Or at the very least lint for versions of PHP for which there aren't unit tests. So like even tho the Travis CI "container" is running PHP 5.6, using Docker containers, it could still lint on PHP 4.4, PHP 5.0, etc. I suppose something else we could do is to have a new build version [i]just[/i] for linting. This build version could be identified by the use of a custom env variable as is done here: ***@***.*** <terrafrost/php-amqplib@317f91e> This .travis.yml might help as well: https://github.com/phpseclib/benchmarks/blob/bcmath-no-openssl/.travis.yml It'd also be good to have this on phpseclib 1.0 since that can run on PHP 4.4+. phpseclib 2.0 requires PHP 5.3+ but it's no longer being tested on PHP 5.3 via continuous integration as of 0539780 <0539780> idk I just think having this linting done via continuous integration would be really cool! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1710 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBQPESTTZ755OZ7DGBEBKDULCQXRANCNFSM5HUEGMDA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.