Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic error reading random bytes from /dev/urandom #1466

Closed
wants to merge 1 commit into from
Closed

Fix logic error reading random bytes from /dev/urandom #1466

wants to merge 1 commit into from

Commits on Apr 2, 2020

  1. Fix logic error reading random bytes from /dev/urandom 

    Fixes a bug introduced in c2be7e6

Previously, this would return those bytes if the number of bytes read
was **less than** the number of bytes this was trying to read.

In practice, I believe this would mean bytes from /dev/urandom would never
get used.  (Noticed when upgrading phpseclib)
    @TysonAndre
    TysonAndre committed Apr 2, 2020
    Copy the full SHA
    978a312 View commit details
    Browse the repository at this point in the history