New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP Fixes found by Static Analysis Tool #1261
base: master
Are you sure you want to change the base?
Conversation
I like how it added the Thanks! |
I think the only commit related to Amy performance (supposed) improvements is this one. I haven't done any benchmarks before but would be willing to do some given a little direction as a best tool to use? like using Blackfire and PHPunit? |
I've never used Blackfire lol. The way I normally benchmark stuff is just to loop over it a million times lol. And in this case I'm not sure a loop would be the most effective way to do the benchmark since I don't really expect anyone to do that stuff in a loop. I guess two possible ideas for benchmarking:
|
Why test performance of comparison operators? It's known that strict comparison is faster and benchmark proves it (approx 15% faster) https://github.com/8ctopus/php-benchmark Typehint performance difference is negligible 0.4 ms per 100M cycles |
No description provided.