$progressCallback should be called after a specific amount of data ha…

…s been received and not, if its just requested, as the requested packets might be more as the available and received data.
phpseclib · Oct 31, 2020 · b2ae60f · b2ae60f · terrafrost · Aug 30, 2021
1 parent 00c9edc
commit b2ae60f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/phpseclib/Net/SFTP.php b/phpseclib/Net/SFTP.php
@@ -2309,9 +2309,6 @@ function get($remote_file, $local_file = false, $offset = 0, $length = -1, $prog
                 }
                 $packet = null;
                 $read+= $packet_size;
-                if (is_callable($progressCallback)) {
-                    call_user_func($progressCallback, $read);
-                }
                 $i++;
             }
 
@@ -2341,6 +2338,9 @@ function get($remote_file, $local_file = false, $offset = 0, $length = -1, $prog
                         } else {
                             fputs($fp, $temp);
                         }
+                        if (is_callable($progressCallback)) {
+                            call_user_func($progressCallback, $offset);
+                        }
                         $temp = null;
                         break;
                     case NET_SFTP_STATUS: