Fixes binary response error in tests #314
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
reviewed
Aug 28, 2020
| @@ -36,7 +36,7 @@ public function convert( | |||
| ); | |||
|
|
|||
| $requestHeaders = trim($requestParts[0] ?? ''); | |||
There was a problem hiding this comment.
Is this still the best way to fetch the formatter headers?
There was a problem hiding this comment.
I looked into it, the getHeaders returns it as an array of ['header-name' => ['value1', 'value2']]
That might not be optimal, and the current solution seems to be working fine for now.
veewee
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You could get this as body in the tests:
This fixes that, so that valid xml is returned instead.