Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catch exception incase of PHP errors #15925

Closed
wants to merge 1 commit into from

Conversation

bismitaguha
Copy link
Contributor

Signed-off-by: Bismita Guha bguha@mt.iitr.ac.in

Description

Added try-catch to MonitorController.php to display warnings.

Fixes #15897

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Signed-off-by: Bismita Guha <bguha@mt.iitr.ac.in>
@williamdes williamdes added this to In progress in pull-requests via automation Feb 6, 2020
@williamdes
Copy link
Member

@bismitaguha what are the warnings?
Can you say what throws the warnings in the code?

@bismitaguha
Copy link
Contributor Author

@williamdes Any kind of PHP error is caught and the warning displayed is the $err->message of the Exception caught.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not agree with this change because it is a hack that will not fix all possible issues.
User must have iconv extension.

pull-requests automation moved this from In progress to Review in progress Feb 9, 2020
@williamdes williamdes closed this Feb 9, 2020
pull-requests automation moved this from Review in progress to Done Feb 9, 2020
@williamdes williamdes self-assigned this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
pull-requests
  
Done
Development

Successfully merging this pull request may close these issues.

Server status monitor not works
3 participants