Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/11161] Include base ext/ directory #1027

Closed
wants to merge 1 commit into from

Conversation

EXreaction
Copy link
Contributor

@michaelcullum
Copy link
Member

cc/ @naderman

@bantu
Copy link
Collaborator

bantu commented Oct 30, 2012

Patch seem okay to me.

@michaelcullum
Copy link
Member

unknownbliss: so, do you disagree with this patch? #1027 (comment)
No, I wanted to see nils comments
as im sure he had a good reason to not have an empty ext/ directory when he did the extensions inital stuff last year
and as he didnt comment in the RFC i thought it might be wise to get a comment from him before merging it?
ok

@imkingdavid
Copy link
Contributor

Relevant IRC Discussion (10/31/2012 ~1:42 PM EDT)

naderman: #1027 - tldr: did you leave out an "empty" ext/ directory on purpose when doing the initial extensions work?
yeah I did, like the config.php file
but I guess it really doesn't matter for the ext dir
then again imho we should be creating that in the build process
and not in the repo
there is no need to maintain any empty directories

In short, the empty ext/ directory should be created during build process (i.e. when the final release package is created) but not in the repo.

@p
Copy link
Contributor

p commented Nov 2, 2012

@imkingdavid
Copy link
Contributor

Replaced by #1032

@imkingdavid imkingdavid closed this Nov 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants