add template annotations on Compiler #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, Psalm doesn't seem to be aware of the template on SplPriorityQueue. Solving the issue for phpstan creates one for Psalm. I'll investigate a little to see if there are simple solution, otherwise this could be ignored in psalm configs, Phpstan seems more detailed in this case. |
…pect template annotation to SplPriorityQueue
|
I ignored the issue in Psalm. It could be added as a stub to add the missing functionality but I don't know the class well enough to try this right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some errors reported by phpstan on the last build.
The last error on the build seems related to phpstan/phpstan#3415. Let's see if it's fixed soon, otherwise I'll create a PR to ignore this error.