RFC: array_find #14108
Merged
RFC: array_find #14108
+757
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaruesweg
force-pushed
the
array_find
branch
2 times, most recently
from
cf2400c
to
828fda5
Compare
morrisonlevi
reviewed
May 2, 2024
TimWolla
reviewed
May 26, 2024
| @@ -6581,6 +6581,165 @@ PHP_FUNCTION(array_filter) | |||
| } | |||
| /* }}} */ | |||
|
|
|||
| /* {{{ Internal function to find an array element for a user closure. */ | |||
| static zend_result php_array_find(const HashTable *array, zend_fcall_info fci, zend_fcall_info_cache fci_cache, zval *result_key, zval *result_value, bool negate_condition) | |||
There was a problem hiding this comment.
Anyone have an objection to making this ZEND_API?
There was a problem hiding this comment.
I have no disagreement. I have chosen a lower visibility for the time being, as it is always easier to increase visibility afterwards instead of reducing it. But if you see a more global use case for the method, we can make it ZEND_API.
There was a problem hiding this comment.
I've now merged this as-is. The PHPAPI can be added in a follow-up commit if necessary/desired.
|
@joshuaruesweg The build on master was briefly broken, a rebase will fix CI here. Sorry for that. |
TimWolla
approved these changes
May 29, 2024
|
Now merged, thank you. Don't forget to adjust the RFC status to "Implemented" and to add the link to the implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/array_find
Closes #13996