-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the condition for result set values to be of native type, making it compatible with previous versions. #11616
Fixed the condition for result set values to be of native type, making it compatible with previous versions. #11616
Conversation
return false; | ||
} | ||
unsigned int int_and_float_native = !bval; | ||
pdo_mysql_db_handle *H = (pdo_mysql_db_handle *)dbh->driver_data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a redundant code, so I'll fix it later
I tried create test file https://gist.github.com/youkidearitai/eb7d57001810bf9410f9bf6d231d15b2 memo: I set database environment to below.
|
Oh, one point. #11587 target version is PHP 8.1 and newer. @SakiTakamachi If you target PHP 8.1 and newer, please set target branch is |
@iluuu1994 @Girgias What do you think this PR? I'd like hear your thoughts. |
I have a couple of questions about the test.
OK, I see. |
Sorry I don't know. Each to their own.
Mainly, concatenate into one file. Please refer to another phpt files. |
732135b
to
4f4f62f
Compare
I couldn't change the base branch from main, so I recreated the PR. |
I am closing this PR. |
#11587