Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Symfony HttpClient integration tests #330

Closed
wants to merge 4 commits into from
Closed

feat: Add Symfony HttpClient integration tests #330

wants to merge 4 commits into from

Conversation

pvgnd
Copy link
Contributor

@pvgnd pvgnd commented Nov 15, 2020

Context

php-vcr does not seems to work with Symfony HttpClient (#329). Here is the error:
RuntimeException: Unexpected error, could not find curl_getinfo in response or errors

What has been done

  • Integration tests from guzzle have been duplicated for symfony/http-client in order to fix the issue

How to test

Todo

  • Find what is the issue and fix it

@aaa2000
Copy link
Contributor

aaa2000 commented Nov 16, 2020

Maybe, you could apply the following PRs #285 #286 #294 to fix the issue

JeroenVanOort
JeroenVanOort requested changes Nov 18, 2020
View reviewed changes
Copy link
Member

@JeroenVanOort JeroenVanOort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase your branch against the current master? I believe some things got mixed up during the years.

.gitignore Outdated Show resolved Hide resolved
@pvgnd pvgnd force-pushed the symfony-httpclient branch 2 times, most recently from 6b21b47 to 3f925a3 Compare November 21, 2020 19:15
@pvgnd pvgnd marked this pull request as draft November 21, 2020 19:57
@pvgnd pvgnd force-pushed the symfony-httpclient branch 2 times, most recently from 843693b to fc6f7ce Compare November 22, 2020 11:38
@JeroenVanOort
Copy link
Member

Would you be so kind to rebase again? And some tests are still failing.

@pvgnd
Copy link
Contributor Author

pvgnd commented Nov 23, 2020

Yes I'm trying to figure out what is the issue but can't make it work for now

@pvgnd pvgnd force-pushed the symfony-httpclient branch 2 times, most recently from b9b489c to b47e9a0 Compare November 28, 2020 11:19
@Xusifob
Copy link

Xusifob commented Sep 5, 2022

Where is the status on this ?

@pvgnd
Copy link
Contributor Author

pvgnd commented Sep 6, 2022

abandoned

@pvgnd pvgnd closed this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeroenVanOort JeroenVanOort JeroenVanOort requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pvgnd @aaa2000 @JeroenVanOort @Xusifob @clemherreman