BUGFIX: ErrorException in VCR/Storage/Yaml.php:61 #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not return the stat since we don't know the resulting the size that the file will have after having all transformations applied. When including files, PHP 7.4 and newer are sensitive to file size reported by stat.
if the fixture is recently created and it has no content, the parser returns null to $recording. And array-like access to null via $recording[0] will raise an exception. With this little check this behavior is fixed and also all tests will work properly.
|
Since commit |
bwood
reviewed
Apr 27, 2020
| @@ -58,8 +58,10 @@ public function storeRecording(array $recording) | |||
| public function next() | |||
| { | |||
| $recording = $this->yamlParser->parse($this->readNextRecord()); | |||
| $this->current = $recording[0]; | |||
| ++$this->position; | |||
| if (!is_null($recording)) { | |||
There was a problem hiding this comment.
It shouldn't happen, but if $recording = 'some string', unintended things will happen. I'd suggest:
if (is_array($recording) && count($recording))
Tjeerd
pushed a commit
to ibuildingsnl/php-vcr
that referenced
this pull request
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
if the fixture is recently created and it has no content, the parser returns
nullto$recording. And array-like access tonullvia$recording[0]will raise an exception. With this little check this behavior is fixed and also all tests will work properly.What has been done
How to test
Todo
Notes