array_pad on list+explode #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some edge-cases that we encountered during unit-tests, where the response might not carry a body for example.
MrRio
reviewed
Feb 9, 2018
| list($rawHeader, $rawBody) = explode("\r\n\r\n", $response, 2); | ||
|
|
||
| list($rawHeader, $rawBody) = array_pad(explode("\r\n\r\n", $response, 2), 2, ''); |
|
This is missing a unit test and those items from the PR template. |
|
Yupp. I’ve done this from the Github editor.
This might have caused it.
… On 9. Feb 2018, at 16:12, James Hall ***@***.***> wrote:
@MrRio commented on this pull request.
In src/VCR/Util/HttpUtil.php <#242 (comment)>:
> @@ -66,8 +66,8 @@ public static function parseStatus($status)
public static function parseResponse($response)
{
$response = str_replace("HTTP/1.1 100 Continue\r\n\r\n", '', $response);
-
- list($rawHeader, $rawBody) = explode("\r\n\r\n", $response, 2);
+
+ list($rawHeader, $rawBody) = array_pad(explode("\r\n\r\n", $response, 2), 2, '');
Accidental indentation?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#242 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB13cNuELhJGvSqCpJqdpEIapYWu7KWtks5tTGBFgaJpZM4R_-jD>.
|
This was referenced Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some edge-cases that we encountered during unit-tests, where the response might not carry a body for example.
Context
What has been done
How to test
Todo
Notes