Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: Add composer keywords #134

Closed
wants to merge 1 commit into from
Closed

DX: Add composer keywords #134

wants to merge 1 commit into from

Conversation

staabm
Copy link

@staabm staabm commented Feb 20, 2023

as per composer/composer#10960 this allows composer to warn the user, when installing the tool as a project dependency instead of a dev-dependency

@@ -3,6 +3,10 @@
"description": "This tool check syntax of PHP files about 20x faster than serial check.",
"homepage": "https://github.com/php-parallel-lint/PHP-Parallel-Lint",
"license": "BSD-2-Clause",
"keywords": [
"lint",
"static analysis"
Copy link
Author

@staabm staabm Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static analysis is a magic keyword, which makes composer double check, when a project adds php-parallel-lint/php-parallel-lint as a dependency that it might wanne do so as a require-dev-dependency

180196760-daacf9e7-bc0d-4ce2-9936-0c3490bdb86c

Copy link
Collaborator

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks for the PR @staabm !

To be honest, I thought I'd already updated the composer.json for this, but clearly must be a commit I hadn't pulled yet.

@staabm staabm closed this by deleting the head repository Feb 25, 2023
@staabm staabm reopened this Feb 25, 2023
@staabm
Copy link
Author

staabm commented Feb 25, 2023

Closed by mistake

@jrfnl
Copy link
Collaborator

jrfnl commented Mar 3, 2023

Note for merging: I think we should merge this in both the 1.x as well as develop (2.x) branch.

@jrfnl
Copy link
Collaborator

jrfnl commented Mar 27, 2024

Turns out the base branch doesn't exist anymore, making this PR unmergable. I've recreated the PR in #160 and given you credit @staabm . Thanks!

@grogy grogy closed this in #160 Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants