use safe class_exists call to prevent issue with magentos classloader #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
force-pushed
the
dbu-patch-1
branch
2 times, most recently
from
a6fddc8
to
fe30ba3
Compare
nicolas-grekas
approved these changes
Mar 31, 2023
dbu
force-pushed
the
dbu-patch-1
branch
2 times, most recently
from
54f0706
to
8a7be19
Compare
|
can't get the roave check to work unfortunately. lets hope Nyholm/roave-bc-check-docker#32 eventually gets fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
We need to catch exeptions during class_exists, because some classloaders (like magento's) throw an exception if the class does not exist.
Checklist