Make RedirectPlugin final #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
commented
Dec 4, 2018
dbu
force-pushed
the
final-redirect-plugin
branch
from
b7eec3a
to
647415f
Compare
dbu
force-pushed
the
final-redirect-plugin
branch
from
647415f
to
8616247
Compare
|
this is now done. i had to redo the tests that depended on hacking around with the class being tested - imho its much cleaner this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
The plugin is not supposed to be extended. The tests have been hacking into the setup of the plugin itself and need to be adjusted.
Checklist
To Do