Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark classes as final and methods and properties as private #123

Merged
merged 1 commit into from Dec 25, 2018
Merged

mark classes as final and methods and properties as private #123

merged 1 commit into from Dec 25, 2018

Commits on Dec 20, 2018

  1. mark classes as final and methods and properties as private 

    We add interfaces for final classes so that they can be mocked in testing.
We chose to use the Interface suffix here to avoid name clashes, rather than renaming the existing PHP classes.
The interfaces are only relevant for unit testing, we do not expect people to provide their own implementations.

HttpClientPoolItem is purely internal and we therefore don't want an interface for it.
It is marked with @Final and explained to not be meant to extend.
    @dbu
    dbu committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    fadb51a View commit details
    Browse the repository at this point in the history