Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Symfony versions #58

Closed
wants to merge 1 commit into from

Conversation

deguif
Copy link
Contributor

@deguif deguif commented Jun 5, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

Remove unmaintained Symfony versions.

@deguif
Copy link
Contributor Author

deguif commented Jun 5, 2019

Fully inspired by php-http/HttplugBundle#343

@GrahamCampbell
Copy link
Contributor

This seems too brutal tbh. Like, all that will happen here that composer will start to resolve older patch releases of this package in order to let people use older symfony. Is this really what we want?

@deguif
Copy link
Contributor Author

deguif commented Jun 5, 2019

You're right about the impact.
This will have more impact here than in the HttplugBundle. Probably a bad idea ;)

@dbu
Copy link
Contributor

dbu commented Jun 5, 2019

my position is: if we get hindered by something (new features, BC breaks etc) we should not hesitate to restrict to only supported symfony versions. but without the need for it, i see no harm in allowing them.

the options resolver probably did not change much over all these versions, so we don't gain anything by excluding older versions.

@deguif
Copy link
Contributor Author

deguif commented Jun 5, 2019

Yes, I should have thought twice before opening this PR. Let's close it.

@deguif deguif closed this Jun 5, 2019
@dbu
Copy link
Contributor

dbu commented Jun 5, 2019

👍 and no worries, i rather have merge requests that we end up not merging than people not caring ;-)

if you want to contribute something, how about picking up php-http/HttplugBundle#319 ? i won't get to work on that this month, so its up for grabs. or there is a couple of issues for the cache-plugin that could be interesting to implement (and require less symfony configuration knowhow) https://github.com/php-http/cache-plugin/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants