New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove more Symfony 4 specific code #443
Conversation
} else { | ||
$loader->load('services_legacy_sf4.xml'); | ||
} | ||
$loader->load('services_legacy.xml'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could completely remove the legacy services and mention in the changelog what the new names to use are. or prefer to do that in a separate MR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can do this here. I take it, this means to also remove the service alias in the services.xml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Psr\Http\Client\ClientInterface
should still be autowireable. so i think that should stay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I misunderstood what this when I first adjusted the xml config. Both legacy XML files triggered a deprecation if Http\Client\HttpClient
was used. I first read this the wrong way and thought it created a httplug.client
alias.
…r `Http\Client\HttpClient`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
What's in this PR?
Remove more Symfony 4 specific code
Why?
Support has been removed #441
To Do
httplug.client
service? Then I move it to the services.yaml.