Symfony5 #360
Symfony5 #360
Conversation
dbu
force-pushed
the
symfony5
branch
6 times, most recently
from
b7fecec
to
57881a3
Compare
|
@dbu Looks good. Can you merge this PR into master so we can test it before releasing? |
|
Possible to see this in a release? Seems like a fix for issue I'm having in Symfony 4.4 as well. |
|
soon. we are wrapping some things up and hope to tag later this week. 🎅 🎁 |
|
Anything I can do to help getting this released before Christmas? 🎄 🌟 ? |
|
hi ruudk, the problem is the cache plugin. we recently merged a contribution for blacklisting urls from being cached, and there is confusion on php-http/cache-plugin#62 but the author is not responding. there i tend to reject the change and keep things as they are. if you can have a look at it and input your impression, that would help. there are #361 and #362 that i'd want to merge to the bundle before tagging. if you could pick those branches, wrap things up and do a new PR with the whole thing, that would help indeed. |
|
I checked all 3 PR's, and they are all from the same author, that doesn't respond to feedback anymore. Is it that important to hold the release? Can't it be done in the next version? The worst that could happen is that it requires another minor version? |
|
ftr: tobias tagged 1.17.0 |
What's in this PR?
Continue #357 and make sure symfony 5 can actually be installed and does not error.
Checklist