Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiler dot client #299

Merged
merged 2 commits into from Jan 3, 2019
Merged

Profiler dot client #299

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb2090e
Add extension to slugify client name for selectors
sowbiba Jan 2, 2019
9dd2636
Add stack.getClientSlug, remove slugify extension
sowbiba Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -2,6 +2,12 @@

The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.

## 1.14.1
sowbiba marked this conversation as resolved.
Show resolved Hide resolved

### Fixed

- Profiler does not display stack when client name contains dots

## 1.14.0

### Added
Expand Down
36 changes: 36 additions & 0 deletions Collector/Twig/HttpPlugSlugifyExtension.php
View file
Open in desktop
@@ -0,0 +1,36 @@
<?php

namespace Http\HttplugBundle\Collector\Twig;

/**
* @author Ibrahima SOW <sowbiba@hotmail.com>
*/
class HttpPlugSlugifyExtension extends \Twig_Extension
{
/**
* {@inheritdoc}
*
* @return array
*/
public function getFilters()
{
return [
new \Twig_SimpleFilter('httplug_slugify', [$this, 'slugify'], ['is_safe' => ['html']]),
];
}

/**
* @param $string
*
* @return string
*/
public function slugify($string)
{
return preg_replace('/[^a-zA-Z0-9_-]/u', '_', $string);
}

public function getName()
{
return 'httplug_slugify';
}
}
4 changes: 4 additions & 0 deletions Resources/config/data-collector.xml
View file
Open in desktop
Expand Up @@ -26,6 +26,10 @@
<tag name="twig.extension" />
</service>

<service id="httplug.collector.twig.httplug_slugify" class="Http\HttplugBundle\Collector\Twig\HttpPlugSlugifyExtension" public="false">
<tag name="twig.extension" />
</service>

<!-- Discovered clients -->
<service id="httplug.collector.auto_discovered_client" class="Http\HttplugBundle\Collector\ProfileClient" decorates="httplug.auto_discovery.auto_discovered_client" public="false">
<argument type="service" id="httplug.collector.auto_discovered_client.inner"/>
Expand Down
10 changes: 5 additions & 5 deletions Resources/views/stack.html.twig
View file
Open in desktop
@@ -1,4 +1,4 @@
<div class="httplug-stack-header httplug-toggle" data-toggle="#httplug-{{ client }}-{{ id }}-details">
<div class="httplug-stack-header httplug-toggle" data-toggle="#httplug-{{ client|httplug_slugify }}-{{ id }}-details">
<div>
{% if stack.failed %}
<span class="httplug-stack-failed">✘</span>
Expand All @@ -23,14 +23,14 @@
{% endif %}
</div>
</div>
<div id="httplug-{{ client }}-{{ id }}-details" class="httplug-hidden">
<div id="httplug-{{ client|httplug_slugify }}-{{ id }}-details" class="httplug-hidden">
<div class="httplug-toolbar">
<div class="httplug-copy-as-curl">
<input readonly="readonly" type="text" value="{{ stack.curlCommand }}" />
<button class="btn tooltip-toggle" aria-label="Copy to clipboard">Copy to clipboard</button>
</div>
<button data-toggle="#httplug-{{ client }}-{{ id }}-stack" class="httplug-toggle btn" >Toggle plugin stack</button>
<button data-toggle="#httplug-{{ client }}-{{ id }}-details .httplug-http-body" class="httplug-toggle btn">Toggle body</button>
<button data-toggle="#httplug-{{ client|httplug_slugify }}-{{ id }}-stack" class="httplug-toggle btn" >Toggle plugin stack</button>
<button data-toggle="#httplug-{{ client|httplug_slugify }}-{{ id }}-details .httplug-http-body" class="httplug-toggle btn">Toggle body</button>
</div>
<div class="httplug-messages">
<div class="httplug-message card">
Expand All @@ -43,7 +43,7 @@
</div>
</div>
{% if stack.profiles %}
<div id="httplug-{{ client }}-{{ id }}-stack" class="httplug-hidden card">
<div id="httplug-{{ client|httplug_slugify }}-{{ id }}-stack" class="httplug-hidden card">
{% for profile in stack.profiles %}
<h3 class="httplug-plugin-name">{{ profile.plugin }}</h3>
<div class="httplug-messages">
Expand Down