Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped php-http/cache-plugin option blacklisted_paths #362

Merged

Conversation

schroedingerskatze42
Copy link
Contributor

Added option for a list of regular expressions to match paths not to be cached.

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Related tickets -
Documentation php-http/documentation@f04eb3b
License MIT

What's in this PR?

Adding blacklisted_paths option of cache plugin

Why?

New option.

Example Usage

httplug: 
    cache:
        config:
            blacklisted_paths: ['\/path\/not-to-be\/cached']

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • [-] Documentation pull request created (if not simply a bugfix) - Already done: php-http/documentation@f04eb3b

 - list of regular expressions to match paths not to be cached.
@dbu
Copy link
Collaborator

dbu commented Dec 2, 2019

thanks! i will wait with merging until we tag a release of the cache plugin.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I like this PR.

You could improve it with one small change. If you have a good reason why I am wrong, then please tell.

Oh, even better, remove the delimiter from the config and let the user add their own. =)

src/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
tests/Resources/Fixtures/config/full.php Outdated Show resolved Hide resolved
tests/Resources/Fixtures/config/full.xml Outdated Show resolved Hide resolved
tests/Resources/Fixtures/config/full.yml Outdated Show resolved Hide resolved
tests/Unit/DependencyInjection/ConfigurationTest.php Outdated Show resolved Hide resolved
@Nyholm Nyholm mentioned this pull request Dec 16, 2019
@Nyholm
Copy link
Member

Nyholm commented Dec 16, 2019

Could you also update composer.json in require dev to fetch cache-plugin 1.7? (We will soon release that version)

@dbu dbu mentioned this pull request Dec 25, 2019
1 task
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR.

Thank you @nobYsDarling for the feature.

@Nyholm Nyholm merged commit f83ab03 into php-http:master Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants