Profiler dot client #299
Merged
Profiler dot client #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Jan 2, 2019
dbu
reviewed
Jan 2, 2019
dbu
approved these changes
Jan 2, 2019
Update Changelog Rename extension from slugify to httplug_slugify Rename extension from slugify to httplug_slugify Rename extension from slugify to httplug_slugify
Nyholm
requested changes
Jan 3, 2019
There was a problem hiding this comment.
Thank you for this PR. I like the way you addressed this problem. A TwigExtension do make sense if there are a lot of values to slugify. However, It might be a bit overkill in this scenario.
Why couldn't modify Collector::getClientRootStacks to return ['slug' => $client]?
Then we could add a new variable here name clientSlug or something. That would be a 10 line fix, right?
dbu
approved these changes
Jan 3, 2019
|
@Nyholm Thanks for the suggestions. Changes made |
|
Excellent. Thank you @sowbiba |
Nyholm
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Slugify client name used as selector to remove non standard characters
https://www.w3.org/TR/CSS21/syndata.html#characters
Why?
#298
Checklist