Merge pull request #292 from php-http/improve-tests

improve some of the tests
php-http · Dec 13, 2018 · e01c3be · e01c3be
2 parents 480b7fa + 25c52ef
commit e01c3be
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/Tests/Functional/DiscoveryTest.php b/Tests/Functional/DiscoveryTest.php
@@ -4,6 +4,7 @@
 
 use Http\Client\HttpAsyncClient;
 use Http\Client\HttpClient;
+use Http\Discovery\HttpClientDiscovery;
 use Http\HttplugBundle\DependencyInjection\HttplugExtension;
 use Http\Message\MessageFactory;
 use Http\Message\StreamFactory;
@@ -65,5 +66,9 @@ public function testNoDiscoveryFallbacks()
         $this->setDefinition('httplug.async_client.default', new Definition(HttpAsyncClient::class));
 
         $this->load();
+
+        $this->assertContainerBuilderHasService('httplug.client.default', HttpClient::class);
+        $clientDefinition = $this->container->getDefinition('httplug.client.default');
+        $this->assertEquals([HttpClientDiscovery::class, 'find'], $clientDefinition->getFactory());
     }
 }
diff --git a/Tests/Unit/Collector/FormatterTest.php b/Tests/Unit/Collector/FormatterTest.php
@@ -14,12 +14,12 @@
 class FormatterTest extends TestCase
 {
     /**
-     * @var MessageFormatter
+     * @var MessageFormatter|\PHPUnit_Framework_MockObject_MockObject
      */
     private $formatter;
 
     /**
-     * @var MessageFormatter
+     * @var CurlCommandFormatter|\PHPUnit_Framework_MockObject_MockObject
      */
     private $curlFormatter;
 

diff --git a/Tests/Unit/DependencyInjection/HttplugExtensionTest.php b/Tests/Unit/DependencyInjection/HttplugExtensionTest.php
@@ -2,6 +2,7 @@
 
 namespace Http\HttplugBundle\Tests\Unit\DependencyInjection;
 
+use Http\Client\HttpClient;
 use Http\HttplugBundle\Collector\PluginClientFactoryListener;
 use Http\HttplugBundle\DependencyInjection\HttplugExtension;
 use Matthias\SymfonyDependencyInjectionTest\PhpUnit\AbstractExtensionTestCase;
@@ -265,6 +266,7 @@ public function testUsingServiceKeyForClients()
     private function verifyProfilingDisabled()
     {
         $def = $this->container->findDefinition('httplug.client');
+        $this->assertTrue(is_subclass_of($def->getClass(), HttpClient::class));
         $arguments = $def->getArguments();
 
         if (isset($arguments[3])) {