Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unneeded dep on psr/http-message #15

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Removing unneeded dep on psr/http-message #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89fb05a
Removing unneeded dep on psr/http-message
Jean85 Mar 26, 2019
3f98077
Fix broken JSON
Jean85 May 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@
}
],
"require": {
"php": "^5.3 || ^7.0",
"psr/http-message": "^1.0"
"php": "^5.3 || ^7.0"
},
"suggest": {
"psr/http-message": "The package containing the PSR-7 interfaces"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this package was intended as a direct utility for the PSR-7 package it makes sense to suggest it.
But in hinsight of what the package currently provides (generally usable HTTP related constants), it isn't even necessary to suggest the other package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the suggestion is still a good idea; it's not saying you MUST install them, but it IS indicating that the primary reason they exist is for that package.

},
"autoload": {
"psr-4": {
Expand Down