Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update references to renamed binary #256

Merged
merged 1 commit into from Dec 11, 2017
Merged

update references to renamed binary #256

merged 1 commit into from Dec 11, 2017

Conversation

abacaphiliac
Copy link
Contributor

No description provided.

@OndraM
Copy link

OndraM commented Dec 11, 2017

Confirmed here as well, we are unable to send coverage when using current master branch (or 2.0.0):

When running composer update:

Skipped installation of bin bin/coveralls for package php-coveralls/php-coveralls: file not found in package

Workaround is to use binary vendor/php-coveralls/php-coveralls/bin/php-coveralls directly...

@keradus keradus changed the base branch from master to 2.0 December 11, 2017 11:06
@keradus keradus changed the title update references to renamed binary. update references to renamed binary Dec 11, 2017
@keradus
Copy link
Member

keradus commented Dec 11, 2017

composer/bin was fine in 2.0, simply master wasnt updated yet.
i changed target branch to 2.0 of this PR

@keradus keradus merged commit 90d87f4 into php-coveralls:2.0 Dec 11, 2017
@keradus
Copy link
Member

keradus commented Dec 11, 2017

Thank you @abacaphiliac

@abacaphiliac
Copy link
Contributor Author

my pleasure, thanks for the merge. sorry about the incorrect target : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants